Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] make buffers zero-dim in exploration modules #2591

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[BugFix] make buffers zero-dim in exploration modules #2591

merged 1 commit into from
Nov 20, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 20, 2024 •
edited
Loading

@vmoens
Update
e58c5ed 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2591

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 11 New Failures, 5 Unrelated Failures

As of commit e58c5ed with merge base 0f59226 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vmoens vmoens mentioned this pull request Nov 20, 2024
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@vmoens vmoens added the bug Something isn't working label Nov 20, 2024
@vmoens vmoens merged commit e58c5ed into gh/vmoens/43/base Nov 20, 2024
50 of 63 checks passed
vmoens added a commit that referenced this pull request Nov 20, 2024
@vmoens
[BugFix] make buffers zero-dim in exploration modules
a47b32c 
ghstack-source-id: fd2705eb9132169da4871b27b354f7895c644061
Pull Request resolved: #2591
@vmoens vmoens deleted the gh/vmoens/43/head branch November 20, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot